Allowing for multiple events of same name to be raised in parallel #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Lettieri <[email protected]>
Signed-off-by: Ryan Lettieri <[email protected]>
Signed-off-by: Ryan Lettieri <[email protected]>
cgillum
reviewed
Sep 22, 2023
tmacam
reviewed
Sep 22, 2023
eng/proto
Outdated
There was a problem hiding this comment.
I don't think this change here was intentional, was it?
jviau
approved these changes
Sep 26, 2023
src/Worker/Core/Shims/TaskOrchestrationContextWrapper.EventSource.cs
Outdated
Show resolved
Hide resolved
| @@ -14,7 +14,7 @@ namespace Microsoft.DurableTask.Worker.Shims; | |||
| /// </summary> | |||
| sealed partial class TaskOrchestrationContextWrapper : TaskOrchestrationContext | |||
| { | |||
| readonly Dictionary<string, IEventSource> externalEventSources = new(StringComparer.OrdinalIgnoreCase); | |||
| readonly Dictionary<string, Queue<IEventSource>> externalEventSources = new(StringComparer.OrdinalIgnoreCase); | |||
There was a problem hiding this comment.
I am not sure what the typical event usage is, but I am going to hazard a guess single events are common. In which case allocating a queue for it is not optimal. We will have to revisit this and see if there is a way to optimize for a few element count cases.
There was a problem hiding this comment.
Agreed we should revisit this. It turns out we do the same thing with the NamedQueue<string> class for buffered events, so we should consider optimizing both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change stems from the following issue discovered in dapr: dapr/dotnet-sdk#1129